Skip to content

Add new keyboard shortcut entry for Add Cursor at Next Match #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tirtawr
Copy link
Contributor

@tirtawr tirtawr commented Mar 18, 2020

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@tirtawr tirtawr mentioned this pull request Mar 18, 2020
3 tasks
@andrewn
Copy link
Member

andrewn commented Mar 27, 2020

Thanks for opening this PR!

I can't find an issue discussing this change. We already have "Find Next Text Match" ({metaKeyName} + G) in the shortcuts help list. Could you explain what the difference is between that and "Add Cursor at Next Text Match" ({metaKeyName} + D)?

I don't think we should add shortcuts if they do similar things. Thanks!

@tirtawr
Copy link
Contributor Author

tirtawr commented Mar 27, 2020

@andrewn I probably should have added an issue prior to this, my bad. "Find Next Text Match" is just a normal text search. "Add Cursor at Next Text Match" on the other hand, adds a cursor at the next text match, it's a feature of codemirror. Great for renaming variables or texts.

@catarak
Copy link
Member

catarak commented Apr 7, 2020

Thanks for opening this PR! The web editor has Sublime Text keyboard shortcuts built in and maybe it makes more sense to just say something like "Text editing keyboard shortcuts are like Sublime Text" and link to sublime text keyboard shortcuts?

@catarak
Copy link
Member

catarak commented Apr 7, 2020

(This seems like a pretty nice list: https://shortcuts.design/toolspage-sublimetext.html)

@catarak catarak closed this May 26, 2020
@catarak catarak reopened this May 26, 2020
@tirtawr tirtawr mentioned this pull request May 26, 2020
3 tasks
@tirtawr
Copy link
Contributor Author

tirtawr commented May 26, 2020

seems like I messed up this branch, I'm moving this to #1438

@tirtawr tirtawr closed this May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants